refact: fix some code style with check plugin by seagle-yuan · Pull Request #385 · apache/hugegraph-toolchain

seagle-yuan · 2022-11-28T08:32:42Z

fix checkstyle check

codecov · 2022-11-28T09:09:15Z

Codecov Report

Attention: Patch coverage is 24.48980% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 62.54%. Comparing base (0a72868) to head (c410bb7).
Report is 94 commits behind head on master.

Files	Patch %	Lines
.../hugegraph/loader/flink/HugeGraphOutputFormat.java	0.00%	11 Missing ⚠️
...e/hugegraph/loader/spark/HugeGraphSparkLoader.java	0.00%	11 Missing ⚠️
...e/hugegraph/serializer/direct/HBaseSerializer.java	0.00%	8 Missing ⚠️
...e/hugegraph/serializer/direct/reuse/BytesDemo.java	0.00%	6 Missing ⚠️
...rg/apache/hugegraph/exception/ServerException.java	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #385      +/-   ##
============================================
- Coverage     62.58%   62.54%   -0.04%     
- Complexity      894     1866     +972     
============================================
  Files            91      260     +169     
  Lines          4383     9407    +5024     
  Branches        515      872     +357     
============================================
+ Hits           2743     5884    +3141     
- Misses         1437     3141    +1704     
- Partials        203      382     +179

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

imbajin · 2022-11-28T09:44:32Z

hugegraph-client/src/main/java/org/apache/hugegraph/exception/ServerException.java

            exception.cause = (String) getByKeys(json, CAUSE_KEYS);
            exception.trace = getByKeys(json, TRACE_KEYS);
        } catch (Exception ignored) {
+            LOG.error(" ServerException excepiton ");


we need log here? @javeme

and seems have 2 extra spaces

hugegraph-dist/release-docs/licenses/LICENSE-ant-launcher.txt

hugegraph-dist/release-docs/licenses/LICENSE-ant.txt

imbajin · 2022-11-28T09:46:13Z

hugegraph-hubble/hubble-be/src/main/java/org/apache/hugegraph/config/HubbleConfig.java

                conf = path;
            }
        } catch (Exception ignored) {
+            LOG.error("hugeConfig exception");


same question

imbajin · 2022-11-28T09:46:49Z

hugegraph-hubble/hubble-be/src/main/java/org/apache/hugegraph/service/load/LoadTaskService.java

+                vMapping = new org.apache.hugegraph.loader.mapping.VertexMapping(
+                        idFields.get(0), true);


if line < 100, use one line instead

if one line,there is 105 char

hugegraph-loader/src/main/java/org/apache/hugegraph/loader/flink/HugeGraphOutputFormat.java

imbajin · 2022-11-28T09:48:28Z

hugegraph-loader/src/main/java/org/apache/hugegraph/loader/spark/HugeGraphSparkLoader.java

+                request.vertices((List<Vertex>) (Object) graphElements)
+                        .updatingStrategies(updateStrategyMap)
+                        .createIfNotExist(true);


align problem?

imbajin · 2022-11-28T09:49:28Z

hugegraph-loader/src/main/java/org/apache/hugegraph/loader/spark/HugeGraphSparkLoader.java

+                        .updatingStrategies(updateStrategyMap)
+                        .checkVertex(isCheckVertex)
+                        .createIfNotExist(true);


same, and why we change the name? (seems optional)

imbajin · 2022-11-28T09:50:06Z

hugegraph-loader/src/main/java/org/apache/hugegraph/loader/task/InsertTask.java

+                    .updatingStrategies(this.mapping.updateStrategies())
+                    .createIfNotExist(true);


same, and so as others

imbajin · 2022-11-29T13:17:19Z

javeme · 2022-11-29T16:37:07Z

hugegraph-client/src/main/java/org/apache/hugegraph/exception/ServerException.java


    private static final long serialVersionUID = 6335623004322652358L;

+    protected static final Logger LOG = Log.logger(ServerException.class);


mark as private?

javeme · 2022-11-29T16:37:38Z

hugegraph-hubble/hubble-be/src/main/java/org/apache/hugegraph/config/HubbleConfig.java

 @Configuration
 public class HubbleConfig {

+    protected static final Logger LOG = Log.logger(HubbleConfig.class);


javeme · 2022-11-29T16:38:27Z

hugegraph-loader/src/main/java/org/apache/hugegraph/loader/flink/HugeGraphOutputFormat.java

-                        g.updateVertices(req.build());
+                        BatchVertexRequest.Builder request = new BatchVertexRequest.Builder();
+                        request.vertices((List<Vertex>) (Object) graphElements)
+                                .updatingStrategies(updateStrategyMap)


align with '.'

javeme · 2022-11-29T16:39:06Z

hugegraph-loader/src/main/java/org/apache/hugegraph/loader/task/InsertTask.java

-               .createIfNotExist(true);
+            BatchEdgeRequest.Builder request = new BatchEdgeRequest.Builder();
+            request.edges((List<Edge>) (Object) elements)
+                    .updatingStrategies(this.mapping.updateStrategies())


javeme · 2022-11-29T16:39:38Z

hugegraph-loader/src/main/java/org/apache/hugegraph/loader/task/InsertTask.java

-            "not allowed to insert, because already exist a vertex " +
+        "Connection refused",
+        "The server is being shutting down",
+        "not allowed to insert, because already exist a vertex " +


keep the origin style?

imbajin · 2022-12-10T16:54:28Z

@seagle-yuan will this PR fixed before release? (before next week) or just leave it in next release

github-actions · 2023-01-09T21:00:33Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

javeme · 2023-01-13T17:57:35Z

hugegraph-client/src/main/java/org/apache/hugegraph/serializer/direct/reuse/BytesDemo.java

+                add(peter);
+                add(lop);
+                add(vadasB);
+            }};


can we keep the origin style?

javeme · 2023-01-13T17:57:40Z

hugegraph-client/src/main/java/org/apache/hugegraph/serializer/direct/reuse/BytesDemo.java

-            add(peterCreateLop);
-        }};
+                add(peterCreateLop);
+            }};


can we keep the origin style?

github-actions · 2023-02-12T21:00:23Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2023-03-15T21:00:24Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2023-06-30T21:00:26Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

liuxiaocs7 · 2023-07-18T02:40:45Z

Hi, @seagle-yuan, any update with this?

imbajin · 2023-07-18T03:35:46Z

Hi, @seagle-yuan, any update with this?

could follow this PR and finish it

github-actions · 2023-08-17T21:00:29Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2024-12-11T21:00:27Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2025-01-16T21:00:21Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2025-02-16T21:00:28Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2025-03-20T21:00:28Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2025-04-21T21:00:25Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2025-05-23T21:00:32Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2025-06-25T21:00:36Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2025-07-27T21:00:22Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

github-actions · 2025-09-02T21:00:25Z

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

fix checkstyle check

da6a09e

imbajin reviewed Nov 28, 2022

View reviewed changes

yuanbingze and others added 3 commits November 28, 2022 18:29

delete blankspace

1816199

delete HugeGraphOutputFormat extra space

6eddbc8

Merge branch 'apache:master' into checkstyle

c410bb7

javeme reviewed Nov 29, 2022

View reviewed changes

imbajin changed the title ~~fix checkstyle check~~ refact: fix some code style with check plugin Dec 10, 2022

github-actions bot added the inactive label Jan 9, 2023

javeme removed the inactive label Jan 11, 2023

javeme reviewed Jan 13, 2023

View reviewed changes

github-actions bot added the inactive label Feb 12, 2023

javeme added ci Continuous integration and removed inactive labels Feb 13, 2023

github-actions bot added the inactive label Mar 15, 2023

javeme removed the inactive label May 31, 2023

github-actions bot added the inactive label Jun 30, 2023

javeme removed the inactive label Jul 1, 2023

liuxiaocs7 mentioned this pull request Aug 1, 2023

fix: checkstyle && add suppressions.xml #500

Merged

github-actions bot added the inactive label Aug 17, 2023

JackyYangPassion removed the inactive label Aug 19, 2023

github-actions bot added inactive and removed inactive labels Oct 15, 2024

github-actions bot added inactive and removed inactive labels Dec 11, 2024

github-actions bot added inactive and removed inactive labels Jan 16, 2025

github-actions bot added inactive and removed inactive labels Feb 16, 2025

github-actions bot added inactive and removed inactive labels Mar 20, 2025

github-actions bot added inactive and removed inactive labels Apr 21, 2025

github-actions bot added inactive and removed inactive labels May 23, 2025

imbajin marked this pull request as draft May 26, 2025 13:03

github-actions bot added inactive and removed inactive labels Jun 25, 2025

github-actions bot added inactive and removed inactive labels Jul 27, 2025

github-actions bot added inactive and removed inactive labels Sep 2, 2025

		vMapping = new org.apache.hugegraph.loader.mapping.VertexMapping(
		idFields.get(0), true);

		.updatingStrategies(this.mapping.updateStrategies())
		.createIfNotExist(true);


		private static final long serialVersionUID = 6335623004322652358L;

		protected static final Logger LOG = Log.logger(ServerException.class);

Comments

Conversation

seagle-yuan commented Nov 28, 2022

Uh oh!

codecov bot commented Nov 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imbajin commented Nov 29, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imbajin commented Dec 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 9, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 12, 2023

Uh oh!

github-actions bot commented Mar 15, 2023

Uh oh!

github-actions bot commented Jun 30, 2023

Uh oh!

liuxiaocs7 commented Jul 18, 2023

Uh oh!

imbajin commented Jul 18, 2023

Uh oh!

github-actions bot commented Aug 17, 2023

Uh oh!

github-actions bot commented Dec 11, 2024

Uh oh!

github-actions bot commented Jan 16, 2025

Uh oh!

github-actions bot commented Feb 16, 2025

Uh oh!

github-actions bot commented Mar 20, 2025

Uh oh!

github-actions bot commented Apr 21, 2025

Uh oh!

github-actions bot commented May 23, 2025

Uh oh!

github-actions bot commented Jun 25, 2025

Uh oh!

github-actions bot commented Jul 27, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

codecov bot commented Nov 28, 2022 •

edited

Loading

imbajin commented Dec 10, 2022 •

edited

Loading