fix: checkstyle && add suppressions.xml#500
Merged
imbajin merged 7 commits intoapache:masterfrom Sep 4, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #500 +/- ##
============================================
- Coverage 62.48% 62.48% -0.01%
Complexity 1868 1868
============================================
Files 260 260
Lines 9432 9434 +2
Branches 875 875
============================================
+ Hits 5894 5895 +1
- Misses 3154 3155 +1
Partials 384 384
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin
reviewed
Aug 1, 2023
Member
imbajin
left a comment
There was a problem hiding this comment.
could also try to clean code? (with IDEA inner plugins)
Co-authored-by: imbajin <jin@apache.org>
|
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label |
imbajin
approved these changes
Sep 1, 2023
z7658329
approved these changes
Sep 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continute this pr: #385
after excludes some questions, it works fine: