Skip to content

Adding rotation based on branch feat/rotate#83

Merged
ardera merged 6 commits intoardera:mainfrom
TID-Test:main
Feb 5, 2026
Merged

Adding rotation based on branch feat/rotate#83
ardera merged 6 commits intoardera:mainfrom
TID-Test:main

Conversation

@TID-Test
Copy link
Contributor

To make it easier when using raspberry pi touch display 2, could we add the rotate argument?

@ardera
Copy link
Owner

ardera commented Jan 31, 2026

Can you add a test similar to this one here?

test('meta-flutter', () async {
var addDeviceWasCalled = false;
config
..addDeviceFn = (entry) {
expect(
entry,
src.DeviceConfigEntry(
id: 'test-device',
sshExecutable: null,
sshRemote: 'test-device',
remoteInstallPath: null,
filesystemLayout: FilesystemLayout.metaFlutter,
),
);
addDeviceWasCalled = true;
}
..containsDeviceFn = (id) {
return false;
};
await _runInTestContext(() async {
await runner.run(
['devices', 'add', 'test-device', '--fs-layout=meta-flutter'],
);
});
expect(
addDeviceWasCalled,
isTrue,
reason: 'addDeviceFn should have been called',
);
});

one test case each for 0, 90, 180 and 270, and one for e.g. 179 and an expect() that it errors in that case.

@ardera
Copy link
Owner

ardera commented Feb 5, 2026

@TID-Test "build test app" failing is not important, just a GH rate limit. Though flutter build workflow says there's a trailing comma missing somewhere

@ardera ardera merged commit 568ba0e into ardera:main Feb 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants