Skip to content

Strict syntax support#336

Merged
nvnieuwk merged 12 commits intoaskimed:mainfrom
nvnieuwk:update/strict-syntax
Jan 22, 2026
Merged

Strict syntax support#336
nvnieuwk merged 12 commits intoaskimed:mainfrom
nvnieuwk:update/strict-syntax

Conversation

@nvnieuwk
Copy link
Collaborator

This pull request attempts to fix all strict syntax related issues. There are still some small issues but most problems have already been fixed. Feel free to take a look already :)

TODOs:

  • Fix errors when running with NXF_SYNTAX_PARSER=v2
  • Add or update tests

@nvnieuwk
Copy link
Collaborator Author

Functions in the lib folder don't work with the current implementation, looking into it right now

@lukfor
Copy link
Collaborator

lukfor commented Jan 21, 2026

Thank you so much for your help!!

@nvnieuwk nvnieuwk marked this pull request as ready for review January 22, 2026 14:19
@nvnieuwk nvnieuwk requested a review from lukfor January 22, 2026 14:20
@nvnieuwk
Copy link
Collaborator Author

This should be ready now!

Copy link
Collaborator

@lukfor lukfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for your time!

@nvnieuwk
Copy link
Collaborator Author

Something to keep in mind: there are still some bugs with the strict syntax which might break things here. I reported all issues I encountered so hopefully this should be fine once 26.04.0 releases

@nvnieuwk nvnieuwk merged commit 350bb14 into askimed:main Jan 22, 2026
12 of 24 checks passed
@nvnieuwk nvnieuwk deleted the update/strict-syntax branch January 22, 2026 15:52
@pinin4fjords
Copy link

Not to be impatient, but is this going into a release soon?

@nvnieuwk
Copy link
Collaborator Author

There's no need to have it released right now since the strict syntax parser still contains some bugs. They should be fixed in the next edge version of Nextflow. I want to be sure first before releasing.

@lukfor is it okay if I ping you when it's ready for a release?

@lukfor
Copy link
Collaborator

lukfor commented Jan 27, 2026

Sure! You have a better sense of when the release is ready to ship. Thanks for taking care of it 🙏

@ewels
Copy link

ewels commented Feb 2, 2026

Hoping to get the next edge release out tomorrow 🤞🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants