fix: improve container dev startup UX and surface runtime errors#346
Merged
fix: improve container dev startup UX and surface runtime errors#346
Conversation
Contributor
Coverage Report
|
5b97c6e to
2300607
Compare
2300607 to
d739b95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the agentcore dev UX for container agents. Previously, when starting a container dev server, the TUI immediately showed a "running" input box while the container image was still building, causing the CLI to appear frozen and unresponsive. Additionally, when the container
runtime failed to start (e.g., Finch VM not running), the error was only visible in log files — the TUI showed a generic "error" status with no explanation.
This PR:
Changes are in DevScreen.tsx and useDevServer.ts (added onReady callback). No new files, types, or dependencies.
Related Issue
Closes #
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
Manual testing:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.