Skip to content

fix: improve container dev startup UX and surface runtime errors#346

Merged
tejaskash merged 1 commit intomainfrom
fix/container-dev-tui
Feb 19, 2026
Merged

fix: improve container dev startup UX and surface runtime errors#346
tejaskash merged 1 commit intomainfrom
fix/container-dev-tui

Conversation

@aidandaly24
Copy link
Contributor

@aidandaly24 aidandaly24 commented Feb 19, 2026

Description

Fixes the agentcore dev UX for container agents. Previously, when starting a container dev server, the TUI immediately showed a "running" input box while the container image was still building, causing the CLI to appear frozen and unresponsive. Additionally, when the container
runtime failed to start (e.g., Finch VM not running), the error was only visible in log files — the TUI showed a generic "error" status with no explanation.

This PR:

  • Shows Status: Starting container... during container build/startup instead of hiding the status line
  • Hides the input box until the server is actually ready (status === 'running')
  • Defers mode transition to 'input' until the server reports readiness via an onReady callback from useDevServer
  • Blocks Enter key during startup to prevent a soft-lock where useInput deactivates but no input box renders
  • Blocks Ctrl+R during startup to prevent queuing a double container start
  • Updates help text during startup to only show quit option
  • Surfaces container runtime errors (e.g., "Found finch but not ready") directly in the TUI header

Changes are in DevScreen.tsx and useDevServer.ts (added onReady callback). No new files, types, or dependencies.

Related Issue

Closes #

Documentation PR

N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Manual testing:

  • Ran agentcore dev with a container agent — confirmed "Starting container..." status displays during build, input box appears only after server is ready
  • Verified Esc to quit works during startup (after build completes, before uvicorn ready)
  • Verified Enter is blocked during startup
  • Verified CodeZip agents show "Starting..." briefly and transition normally
  • Verified container runtime errors (Finch VM not started) display directly in the TUI instead of only in log files

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@aidandaly24 aidandaly24 requested a review from a team February 19, 2026 16:50
@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 43.33% 2860 / 6600
🔵 Statements 42.89% 3008 / 7012
🔵 Functions 45.49% 606 / 1332
🔵 Branches 48.23% 1871 / 3879
Generated in workflow #444 for commit d739b95 by the Vitest Coverage Report Action

@aidandaly24 aidandaly24 force-pushed the fix/container-dev-tui branch from 2300607 to d739b95 Compare February 19, 2026 17:15
@aidandaly24 aidandaly24 changed the title fix: container dev now has a starting container status fix: improve container dev startup UX and surface runtime errors Feb 19, 2026
Copy link
Contributor

@tejaskash tejaskash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tejaskash tejaskash merged commit 3fc5d1f into main Feb 19, 2026
14 of 15 checks passed
@tejaskash tejaskash deleted the fix/container-dev-tui branch February 19, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants