Skip to content
This repository was archived by the owner on Dec 3, 2025. It is now read-only.

chore: remove EoL Python 3.7 from test matrix and other CI improvements #252

Merged
shushen merged 4 commits into from
Nov 3, 2023
Merged

chore: remove EoL Python 3.7 from test matrix and other CI improvements #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76019c7
fix: force int type for random.randint()
Nov 2, 2023
f8c969a
chore: bump github action aws-actions/configure-aws-credentials@v4
Nov 2, 2023
8c253f0
chore: bump Github actions for CodeQL
Nov 2, 2023
c896ab2
chore: remove EoL Python 3.7 from test matrix
Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v1
uses: github/codeql-action/init@v2
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
Expand All @@ -54,7 +54,7 @@ jobs:
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v1
uses: github/codeql-action/autobuild@v2

# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl
Expand All @@ -68,4 +68,4 @@ jobs:
# make release

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v1
uses: github/codeql-action/analyze@v2
8 changes: 4 additions & 4 deletions .github/workflows/pythonapp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,19 @@ jobs:
build:

runs-on: ${{ matrix.os }}
strategy:
strategy:
max-parallel: 6
matrix :
matrix :
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.7', '3.8', '3.9', '3.10']
python-version: ['3.8', '3.9', '3.10']
Copy link
Contributor

@trstephen-amazon trstephen-amazon Nov 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious: do 3.11 and 3.12 work?

Copy link
Contributor Author

@shushen shushen Nov 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, some weird dependency installation failure on Windows with 3.12. See #253 (WIP).

steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v1
uses: aws-actions/configure-aws-credentials@v4
with:
aws-region: us-east-2
role-to-assume: arn:aws:iam::264319671630:role/GitHubActionsOidc
Expand Down
2 changes: 1 addition & 1 deletion pyqldb/util/retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@ def calculate_backoff(retry_config, retry_attempt, error, transaction_id):
def _get_delay_with_equal_jitter(retry_attempt, retry_config):
capped_retries = min(retry_attempt, MAX_POW)
delay_seed = min(retry_config.base * (1 << capped_retries), MAX_BACKOFF)
delay = delay_seed / 2 + random.randint(0, delay_seed / 2)
delay = delay_seed / 2 + random.randint(0, int(delay_seed / 2))

return delay