This repository was archived by the owner on Dec 3, 2025. It is now read-only.
chore: remove EoL Python 3.7 from test matrix and other CI improvements#252
Merged
chore: remove EoL Python 3.7 from test matrix and other CI improvements#252
Conversation
shushen
force-pushed
the
update-test-matrix
branch
from
f45e453 to
1cfd63f
Compare
added 4 commits
November 2, 2023 14:26
Automatic conversion of non-integer types is no longer supported in Python 3.12. See https://docs.python.org/3/library/random.html.
shushen
force-pushed
the
update-test-matrix
branch
from
1cfd63f to
c896ab2
Compare
shushen
changed the title
trstephen-amazon
approved these changes
Nov 3, 2023
Contributor
trstephen-amazon
left a comment
trstephen-amazon
left a comment
There was a problem hiding this comment.
Thoughts on bumping the readme to be "requires Python 3.8 or later"? It should still work on 3.6, until we use features added in later versions!
| matrix : | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| python-version: ['3.7', '3.8', '3.9', '3.10'] | ||
| python-version: ['3.8', '3.9', '3.10'] |
Contributor
There was a problem hiding this comment.
curious: do 3.11 and 3.12 work?
Contributor
Author
There was a problem hiding this comment.
No, some weird dependency installation failure on Windows with 3.12. See #253 (WIP).
Contributor
Author
Will have to update this later when we sorted out the matrix in #253. You are correct, we are only dropping the tests for Python releases no longer supported, which doesn't mean it won't work. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
n/a
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.