feat: CommentPopover for better comment writing UX#220
Merged
backnotprop merged 2 commits intomainfrom Mar 4, 2026
Merged
Conversation
Replace the cramped toolbar textarea and awkward global comment inline form with a new CommentPopover component that provides a proper writing surface for long comments. - New CommentPopover with popover mode (w-96) and expand-to-dialog mode - Simplified AnnotationToolbar to menu-only (removed input step) - Global comment button now opens CommentPopover instead of inline form - Cmd/Ctrl+Enter to submit, Enter for newline (GitHub/Linear pattern) - Popover tracks anchor element on scroll to stay pinned to content - Image attachments supported in both modes Closes #219 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Clear commentPopover state in highlighter CREATE handler when a new selection is made (prevents popover+toolbar coexisting) - Wrap handleCommentClose in useCallback to prevent the click-outside effect from re-registering on every Viewer render Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max-w-80 max-h-32) and awkward global comment inline form with a newCommentPopovercomponentw-96) provides a wider, auto-growing textarea with proper paddingmax-w-xl) for long-form writingAnnotationToolbarto menu-only — removed the entire input step (~100 lines)Test plan
Closes #219
🤖 Generated with Claude Code