fix: CommentPopover closes when adding image attachments#226
Merged
backnotprop merged 1 commit intomainfrom Mar 5, 2026
Merged
fix: CommentPopover closes when adding image attachments#226backnotprop merged 1 commit intomainfrom
backnotprop merged 1 commit intomainfrom
Conversation
…nnotator The click-outside handler matched only z-[90]/z-[100] classes, missing the ImageAnnotator portal at z-[200]. Replace fragile z-index class matching with a data-popover-layer attribute on all overlay portals. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
z-[90]/z-[100]class strings, but the ImageAnnotator renders atz-[200]— so interacting with it closed the popoverdata-popover-layerattribute on all overlay portals (AttachmentsButton backdrop/content, ImageAnnotator)Test plan
🤖 Generated with Claude Code