Skip to content

fix: CommentPopover closes when adding image attachments #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
backnotprop merged 1 commit into from
Mar 5, 2026
Merged

fix: CommentPopover closes when adding image attachments #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/ui/components/AttachmentsButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,12 +242,14 @@ export const AttachmentsButton: React.FC<AttachmentsButtonProps> = ({
{/* Backdrop */}
<div
className="fixed inset-0 z-[90]"
data-popover-layer
onClick={() => setIsOpen(false)}
/>

{/* Popover content */}
<div
className="fixed z-[100] w-72 bg-card border border-border rounded-xl shadow-2xl p-3"
data-popover-layer
style={{ top: position.top, left: position.left }}
onClick={e => e.stopPropagation()}
>
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/components/CommentPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ export const CommentPopover: React.FC<CommentPopoverProps> = ({
const target = e.target as Node | null;
if (!target) return;
if (popoverRef.current?.contains(target)) return;
// Don't close if clicking inside an AttachmentsButton portal (z-index 90+)
// Don't close if clicking inside a child portal (AttachmentsButton, ImageAnnotator, etc.)
const el = target as HTMLElement;
if (el.closest?.('[class*="z-[90]"], [class*="z-[100]"]')) return;
if (el.closest?.('[data-popover-layer]')) return;
onClose();
};

Expand Down
1 change: 1 addition & 0 deletions packages/ui/components/ImageAnnotator/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ export const ImageAnnotator: React.FC<ImageAnnotatorProps> = ({
return (
<div
className="fixed inset-0 z-[200] flex items-center justify-center bg-background/90 backdrop-blur-sm"
data-popover-layer
onClick={handleBackdropClick}
>
{/* Canvas with image and toolbar */}
Expand Down