fix(positioner box): include username in scan queue request#1000
Open
fix(positioner box): include username in scan queue request#1000
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the scan_queue_request API call to include the username parameter, aligning with changes in the upstream BEC library (PR #725) to support user-scoped scan queue requests.
- Updated
_stop_devicemethod to passself.client.usernametoMessageEndpoints.scan_queue_request() - Updated corresponding unit test to verify the username parameter is correctly passed
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
bec_widgets/widgets/control/device_control/positioner_box/_base/positioner_box_base.py |
Modified the _stop_device method to include self.client.username parameter in the scan queue request call |
tests/unit_tests/test_positioner_box.py |
Updated test assertion to verify the username parameter is correctly passed to the scan queue request endpoint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+101
to
+103
| mock_send.assert_called_once_with( | ||
| MessageEndpoints.scan_queue_request(positioner_box.client.username), msg | ||
| ) |
There was a problem hiding this comment.
The mocked_client used in this test does not explicitly set a username attribute. While MagicMock will auto-generate it, consider adding an explicit username to the mocked_client fixture to make the test more realistic and ensure it properly validates the username parameter is being passed correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor patch for compatibility with user-scope scan queue requests, cf. bec-project/bec#725
Definition of Done