Skip to content

fix(positioner box): include username in scan queue request #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wakonig wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix(positioner box): include username in scan queue request #1000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bec_widgets/widgets/control/device_control/positioner_box/_base/positioner_box_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def _stop_device(self, device: str):
queue="emergency",
metadata={"RID": request_id, "response": False},
)
self.client.connector.send(MessageEndpoints.scan_queue_request(), msg)
self.client.connector.send(MessageEndpoints.scan_queue_request(self.client.username), msg)

# pylint: disable=unused-argument
def _on_device_readback(
Expand Down
4 changes: 3 additions & 1 deletion tests/unit_tests/test_positioner_box.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,9 @@ def test_positioner_box_on_stop(positioner_box):
queue="emergency",
metadata={"RID": "fake_uuid", "response": False},
)
mock_send.assert_called_once_with(MessageEndpoints.scan_queue_request(), msg)
mock_send.assert_called_once_with(
MessageEndpoints.scan_queue_request(positioner_box.client.username), msg
)
Comment on lines +101 to +103
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mocked_client used in this test does not explicitly set a username attribute. While MagicMock will auto-generate it, consider adding an explicit username to the mocked_client fixture to make the test more realistic and ensure it properly validates the username parameter is being passed correctly.

Copilot uses AI. Check for mistakes.


def test_positioner_box_setpoint_change(positioner_box):
Expand Down
Loading