include input_name in Table.Reader fields#476
Closed
madlep wants to merge 1 commit intobencheeorg:mainfrom
Closed
Conversation
Member
|
Ah what an oversight! Thanks a lot for pointing that out! 💚 it looks good overall, but I'm a bit tired right now - I'll wanna review it next week with a bit of a fresher mind but it seems to make sense to me. I specifically wanna double check job name vs. scenario name usage in there as well and what makes sense (scenario name should be the aggregated name of job and input).
|
Member
|
Closed in favor of #478 - thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table.Readerimpl doesn't includeinput_namein the list of output fields.When a benchmark with multiple inputs is used in a LiveBook and rendered with kino_benchee, all results are combined into a single chart and resulting output is less useful.
livebook-dev/kino_benchee#7 adds faceted charts to display for each input seprately, but needs this data to be exposed by Benchee.