Skip to content

include input_name in Table.Reader fields #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
madlep wants to merge 1 commit into from
Closed

include input_name in Table.Reader fields #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lib/benchee/suite.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ end

if Code.ensure_loaded?(Table.Reader) do
defimpl Table.Reader, for: Benchee.Suite do
alias Benchee.Benchmark
alias Benchee.CollectionData
alias Benchee.Scenario

Expand Down Expand Up @@ -96,7 +97,7 @@ if Code.ensure_loaded?(Table.Reader) do
Enum.map(fields, fn field -> "#{measurement_type}_#{field}" end)
end)

["job_name" | measurement_headers]
["job_name", "input_name"] ++ measurement_headers
end

defp fields_for(:run_time), do: @run_time_fields
Expand All @@ -113,7 +114,15 @@ if Code.ensure_loaded?(Table.Reader) do
|> get_stats_from_collection_data(measurement_type, config_percentiles)
end)

row = [scenario.job_name | secenario_data]
no_input = Benchmark.no_input()

input_name =
case scenario.input_name do
name when name in [nil, no_input] -> ""
name -> name
end

row = [scenario.job_name, input_name] ++ secenario_data

{row, count + 1}
end)
Expand Down
Loading
Loading