Fix non-constant format strings #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now a problem with Go 1.24, as `go test` does a vet check for it. https://go.dev/doc/go1.24#vet
chrisnovakovic
added a commit
to chrisnovakovic/ar
that referenced
this pull request
Oct 8, 2025
I've rewritten practically the entire module at this point (very few original lines of upstream code remain), so add myself as an author. Jerry made some upstream changes in 2017 that weren't credited in `README.md`, so add them too. Remove the copyright notices from the source files - they're not necessary given that the copyright notice already exists in `COPYING`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now a problem with Go 1.24, as
go testdoes a vet check for it. https://go.dev/doc/go1.24#vet