Skip to content

Fix non-constant format strings #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuLogic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix non-constant format strings #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions reader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ func TestReadHeader(t *testing.T) {
defer f.Close()

if err != nil {
t.Errorf(err.Error())
t.Error(err.Error())
}
reader := NewReader(f)
header, err := reader.Next()
if err != nil {
t.Errorf(err.Error())
t.Error(err.Error())
}

expectedName := "hello.txt"
Expand Down Expand Up @@ -69,12 +69,12 @@ func TestReadBody(t *testing.T) {
defer f.Close()

if err != nil {
t.Errorf(err.Error())
t.Error(err.Error())
}
reader := NewReader(f)
_, err = reader.Next()
if err != nil && err != io.EOF {
t.Errorf(err.Error())
t.Error(err.Error())
}
var buf bytes.Buffer
io.Copy(&buf, reader)
Expand All @@ -91,7 +91,7 @@ func TestReadMulti(t *testing.T) {
defer f.Close()

if err != nil {
t.Errorf(err.Error())
t.Error(err.Error())
}
reader := NewReader(f)
var buf bytes.Buffer
Expand All @@ -101,7 +101,7 @@ func TestReadMulti(t *testing.T) {
break
}
if err != nil {
t.Errorf(err.Error())
t.Error(err.Error())
}
io.Copy(&buf, reader)
}
Expand Down
6 changes: 3 additions & 3 deletions writer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func TestGlobalHeaderWrite(t *testing.T) {
var buf bytes.Buffer
writer := NewWriter(&buf)
if err := writer.WriteGlobalHeader(); err != nil {
t.Errorf(err.Error())
t.Error(err.Error())
}

globalHeader := buf.Bytes()
Expand All @@ -59,15 +59,15 @@ func TestSimpleFile(t *testing.T) {
writer.WriteHeader(hdr)
_, err := writer.Write([]byte(body))
if err != nil {
t.Errorf(err.Error())
t.Error(err.Error())
}

f, _ := os.Open("./fixtures/hello.a")
defer f.Close()

b, err := ioutil.ReadAll(f)
if err != nil {
t.Errorf(err.Error())
t.Error(err.Error())
}

actual := buf.Bytes()
Expand Down