fix: incorrect masks for modem status bits on Windows #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM, thank you! |
cmaglie
approved these changes
May 19, 2025
Member
cmaglie
left a comment
cmaglie
left a comment
There was a problem hiding this comment.
Thanks for the patch!
I've just moved the constants inside the method GetModemStatusBit to make them private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204.
Bring back constants from #187 and revert the code in
GetModemStatusBitsto fix data gathering.Ideally, this enum should get added to
golang.org/x/sys/windowsas @twpayne did for other constants.