Skip to content

fix: incorrect masks for modem status bits on Windows #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 3 commits into from
May 19, 2025
Merged

fix: incorrect masks for modem status bits on Windows #205

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9710c81
fix: incorrect masks for modem status bits on Windows
WarningImHack3r May 7, 2025
20a4794
refactor: rename variables to match docs
WarningImHack3r May 8, 2025
8f447eb
Make win32 internal constants private.
cmaglie May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions serial_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,15 +281,22 @@ func (port *windowsPort) SetRTS(rts bool) error {
}

func (port *windowsPort) GetModemStatusBits() (*ModemStatusBits, error) {
// GetCommModemStatus constants. See https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getcommmodemstatus.
const (
MS_CTS_ON = 0x0010
MS_DSR_ON = 0x0020
MS_RING_ON = 0x0040
MS_RLSD_ON = 0x0080
)
var bits uint32
if err := windows.GetCommModemStatus(port.handle, &bits); err != nil {
return nil, &PortError{}
}
return &ModemStatusBits{
CTS: (bits & windows.EV_CTS) != 0,
DCD: (bits & windows.EV_RLSD) != 0,
DSR: (bits & windows.EV_DSR) != 0,
RI: (bits & windows.EV_RING) != 0,
CTS: (bits & MS_CTS_ON) != 0,
DCD: (bits & MS_RLSD_ON) != 0,
DSR: (bits & MS_DSR_ON) != 0,
RI: (bits & MS_RING_ON) != 0,
}, nil
}

Expand Down Expand Up @@ -366,7 +373,8 @@ func nativeOpen(portName string, mode *Mode) (*windowsPort, error) {
0, nil,
windows.OPEN_EXISTING,
windows.FILE_FLAG_OVERLAPPED,
0)
0,
)
if err != nil {
switch err {
case windows.ERROR_ACCESS_DENIED:
Expand Down