Cucumber

[tommeier]

Description

Initial support for Cucumber.

Testing

Detailed behavioural tests required. Ties in with:

• https://github.com/buildkite/test-collector-ruby/pull/245/files
• [TE-3868] WIP - Add cucumber test example with prototype integration with Ruby Collector test-engine-client-examples#17

[tommeier]

You did all the work @wooly getting this over the line - thank you! will leave for you to merge when you're satisfied

👍

[tommeier]

I did an addendum PR over here for RSpec feature parity #326 (skip & split tests)

[wooly]

SBE is working now:

[nprizal]

Looks great! 🎉
I paired with @wooly at the beginning, and it was working. The test coverage is pretty good, so I'm confident with the changes.

@wooly Have you confirmed that the API return estimated duration for files and examples, and not default value of 1000?

[wooly]

Have you confirmed that the API return estimated duration for files and examples, and not default value of 1000?

It appears they're still on the estimated values, haven't worked out why yet though.

[wooly]

Fixed that issue, was a missing scope. Here we go!

[tommeier]

🎉

[wooly]

🤦 my push failed so I just shipped the PR without the change to make it work.

[niceking]

Woohooooo!! So good!!!