buttonmen-dev/buttonmen#2668 enhance python api#2912
Open
danlangford wants to merge 5 commits intobuttonmen-dev:masterfrom
Open
buttonmen-dev/buttonmen#2668 enhance python api#2912danlangford wants to merge 5 commits intobuttonmen-dev:masterfrom
danlangford wants to merge 5 commits intobuttonmen-dev:masterfrom
Conversation
…hread, load_button_data
…earch_game_historywrap_load_button_data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2668
BMAPI.PY
BMUTILS.PY
I added these years ago. I recently merged in #2667 and I think I resolved any major problems. i could have goofed something up. I wanted to get this infant of you all while I go back and triple validate it
QUESTIONS
should I add a couple reviewers? like @blackshadowshade and @cgolubi1