Skip to content

Error Tracing#1470

Merged
RamilCDISC merged 2 commits intomainfrom
editor_error
Dec 5, 2025
Merged

Error Tracing#1470
RamilCDISC merged 2 commits intomainfrom
editor_error

Conversation

@SFJohnson24
Copy link
Collaborator

This PR changes the internal server error 500 returned by engine to a 400 as well as providing the stack trace as a string. This prevents the 500 error status with no context in editor that occurs when engine fails to execute code. Unfortunately, Azure sanitizes 500 responses for security making them a generic 'Internal Server Error' without any message or context.
image
By converting the error to a 400 code, we are able to get the message and trace in editor to allow for a more informative message to the author. Since our codebase is open source, there is no security risk in exposing our code/stack trace in these errors. While a 400 status code isn't semantically precise for internal server errors, the debugging benefits outweigh this concern.

Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR updates the exception to return status code of 400 instead of 500 along with the traceback for better debugging of errors. The update was validated in the dev editor by providing datasets that result in an exception. The error are correctly displayed in the result section and are readable.

@RamilCDISC RamilCDISC merged commit 36a750b into main Dec 5, 2025
11 checks passed
@RamilCDISC RamilCDISC deleted the editor_error branch December 5, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants