new operation get_library_class_domains#1595
Merged
SFJohnson24 merged 6 commits intomainfrom Feb 12, 2026
Merged
Conversation
RamilCDISC
requested changes
Feb 9, 2026
| ], | ||
| }, | ||
| { | ||
| "name": "Events", |
Collaborator
There was a problem hiding this comment.
The documentation mention: "("TRIAL DESIGN", "FINDINGS", "EVENTS", "INTERVENTIONS). NOTE: Class names are case-sensitive and should match the Library metadata format.
The examples shows all capitals for class names but tests have First letter capital only. Could we please consolidate these.
RamilCDISC
approved these changes
Feb 10, 2026
Collaborator
RamilCDISC
left a comment
RamilCDISC
left a comment
There was a problem hiding this comment.
The PR adds a new operation get_library_class_domains. The validation was done by:
- Reviewing the PR for any unwanted code or comments.
- Reviewing the PR logic in accordance with AC.
- Ensuring all unit and regression testing pass.
- Ensuring new unit tests has been added for the new operation.
- Verifying that the added tests cover all important cases.
- Ensuring the documentation is updated.
- Running manual validation using CLI.
- Running manual validation using dev rule editor.
- Ensuring proper integration with other operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds the new get_library_class_domains() operation as requested by the issue and tests.