library_variable_has_codelist new metadata#1628
Merged
SFJohnson24 merged 10 commits intomainfrom Mar 12, 2026
Merged
Conversation
gerrycampion
requested changes
Feb 25, 2026
Collaborator
There was a problem hiding this comment.
missing updates to test_define_variables_with_library_metadata
Collaborator
Author
|
updated @gerrycampion |
Collaborator
|
@SFJohnson24 do you think it would be a good idea to add 1 or 2 unit tests focused on extraction behavior from _links. Currently the updated tests verify propagation of column only. |
Collaborator
Author
this would likely be done in test_sdtm_utils and not the builder. @RamilCDISC Do you want to make some coverage for the _link extraction using get_variables_metadata_from_standard in a separate PR? |
gerrycampion
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds the new metadata requested from the parent issue to variable metadata with Library builders