Add support for UBI 8 based images in SSHD service#653
Add support for UBI 8 based images in SSHD service#653rgrunber merged 2 commits intoche-incubator:mainfrom
Conversation
Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber
requested review from
RomanNikitenko,
azatsarynnyy and
vitaliy-guliy
as code owners
|
Click here to review and test in web IDE: |
&message=Dev%20cluster%20(for%20maintainers)&logo=eclipseche&color=525C86&labelColor=FDB940)
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-653-amd64 |
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-653-amd64 |
- Use a multi-stage image build to support different UBI based images. - Use folders within /sshd-staging/ to determine base of user container (eg. /sshd-staging/ubi8/ , /sshd-staging/ubi9/) - Place all landing page setup into sshd.init script. Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
There was a problem hiding this comment.
I tested the PR by providing the following editor definition to the Dashboard
https://gist.githubusercontent.com/azatsarynnyy/56a07b64fbd13fac38844baee005971f/raw/43d3517bfdf0aec892e4c63f72f5abf798090f93/editor-over-ssh
It's based on the eclipse-che/che-operator#2088 with the editor image built from the current PR and pushed to quay.io/azatsary/ssh:pr-653
A new workspace, created from the Node.js Runtime sample (which is UBI8-based), started as expected, and local IDE connect:
Roland, thanks for moving the landing page startup command to the sshd.init script. It makes the solution clearer and more flexible. So, the command can be modified w/o introducing the changes to the editor definition yaml files.
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-653-amd64 |
2 participants
This PR is meant to work with the editor definition proposed in eclipse-che/che-operator#2088
/etc/passwd. Before, we would use NSS_WRAPPER to modify the home directory and shell stored for a user (under/etc/passwd), but now we've expanded to also adding the user if not present.