Add support for UBI 8 in che-code-sshd editor definition.#2088
Merged
ibuziuk merged 1 commit intoeclipse-che:mainfrom Feb 24, 2026
Merged
Add support for UBI 8 in che-code-sshd editor definition.#2088ibuziuk merged 1 commit intoeclipse-che:mainfrom
ibuziuk merged 1 commit intoeclipse-che:mainfrom
Conversation
rgrunber
requested review from
SDawley,
dkwon17,
ibuziuk,
mkuznyetsov and
tolusha
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2088 +/- ##
==========================================
+ Coverage 49.92% 50.03% +0.11%
==========================================
Files 94 94
Lines 12561 12551 -10
==========================================
+ Hits 6271 6280 +9
+ Misses 5863 5852 -11
+ Partials 427 419 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tolusha
approved these changes
Feb 19, 2026
rgrunber
commented
Feb 20, 2026
- The che-code-sshd image is now a multi-stage image that supports UBI 8,9 and 10 with appropriate library defined at /sshd-staging/ubi8/ & /sshd-staging/ubi9/ - The che-code-sshd-page container is now only responsible for copying those resources into the /sshd/ volume mount and setting up the landing page with connection instructions, using sshd.init script - Remove 'Tech-Preview' tag Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
ibuziuk
approved these changes
Feb 24, 2026
azatsarynnyy
approved these changes
Feb 24, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: azatsarynnyy, ibuziuk, rgrunber, tolusha The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
azatsarynnyy
left a comment
azatsarynnyy
left a comment
There was a problem hiding this comment.
I tested the patch in che-incubator/che-code#653 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to work with the editor definition proposed in che-incubator/che-code#653 . Simply build the image in the referenced PR, and push it to some image registry. Then in this editor definition, where you see the 2 references to
quay.io/che-incubator/che-code-sshd:next(or insiders), replace it with your built image.I tested this with https://github.com/sbouchet/devworkspace-auto-validation :