Concourse managed server plugin race condition#598
Open
javierlores wants to merge 2 commits intodevelopfrom
Open
Concourse managed server plugin race condition#598javierlores wants to merge 2 commits intodevelopfrom
javierlores wants to merge 2 commits intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ready immediately after server start
Problem
When ClientServerTest starts a server and immediately calls installPlugin(), the management server may not be ready yet, causing the error:
Could not connect to the management server. Please check that Concourse Server is running.
Solution
Added a retry loop in ManagedConcourseServer.installPlugin() that: