Skip to content

Concourse managed server plugin race condition #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
javierlores wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Concourse managed server plugin race condition #598

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26f1f8f
add retry for plugin install
javierlores Feb 12, 2026
4d70223
fixed formatting
javierlores Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 38 additions & 7 deletions ...mation/src/main/java/com/cinchapi/concourse/automation/server/ManagedConcourseServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,22 +690,53 @@ public boolean hasWritesToTransport(String environment) {
/**
* Install the plugin(s) contained in the {@code bundle} on this
* {@link ManagedConcourseServer}.
*
*
* @param bundle the path to the plugin bundle
* @return {@code true} if the plugin(s) from the bundle is/are installed
*/
public boolean installPlugin(Path bundle) {
log.info("Attempting to install plugins from {}", bundle);
List<String> out = executeCli("plugin", "install", bundle.toString(),
"--username admin", "--password admin");
for (String line : out) {
if(line.contains("Successfully installed")) {
return true;
int maxAttempts = 10;
long waitMs = 500;
List<String> out = null;

for (int attempt = 1; attempt <= maxAttempts; attempt++) {
out = executeCli("plugin", "install", bundle.toString(),
"--username admin", "--password admin");

boolean managementServerNotReady = false;
for (String line : out) {
if(line.contains("Successfully installed")) {
return true;
}
if(line.contains(
"Could not connect to the management server")) {
managementServerNotReady = true;
}
}

if(managementServerNotReady && attempt < maxAttempts) {
log.debug(
"Management server not ready, waiting {}ms before retry (attempt {}/{})",
waitMs, attempt, maxAttempts);
try {
Thread.sleep(waitMs);
waitMs = Math.min(waitMs * 2, 5000); // exponential backoff,
// max 5 seconds
}
catch (InterruptedException e) {
Thread.currentThread().interrupt();
break;
}
continue;
}

// Not a management server issue, break and throw
break;
}

throw new RuntimeException(AnyStrings
.format("Unable to install plugin '{}': {}", bundle, out));

}

/**
Expand Down