Conversation
Rayuaz
commented
Apr 13, 2025
Comment on lines
+9
to
14
| body { | ||
| color: $fgSecondary; | ||
| font-family: system-ui, sans-serif; | ||
| font-size: 1rem; | ||
| font-size: 1.125rem; | ||
| line-height: 1.5; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
We were using 1.125rem as the text size pretty much everywhere, so I went ahead and made it the default (and set in on body instead of html because then it keeps the root element as 16px.
Rayuaz
commented
Apr 13, 2025
Collaborator
Author
There was a problem hiding this comment.
Here I removed the classes on the text elements because they are not needed. It's just a rich text content and it's better to let the default styles handle them.
Signed-off-by: Alan Fernandes <alan@cipher.host>
Signed-off-by: Alan Fernandes <alan@cipher.host>
Signed-off-by: Alan Fernandes <alan@cipher.host>
Signed-off-by: Alan Fernandes <alan@cipher.host>
Signed-off-by: Alan Fernandes <alan@cipher.host>
Signed-off-by: Alan Fernandes <alan@cipher.host>
b8c42b0 to
0eba8e4
Compare
Rayuaz
commented
Apr 13, 2025
Comment on lines
-92
to
-93
| <div class="package__instructions"> | ||
| <div class="package__instructionsSection uRichText"> |
Collaborator
Author
There was a problem hiding this comment.
Here I removed this unnecessary .package__instructionsSection section and added .uRichText to its parent, so it can handle the spacing with the default text styles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
uSurfaceutility class for surfaces.Additional Notes
Home
Package Page
Privacy Policy Page
404 Page
Review checklist
Before submitting your PR, please review the following:
my feature works.
documentation (if appropriate).
Developer's certificate of origin
By submitting this pull request, I certify that: