Skip to content

Alan/fix styling issues#4

Merged
jamesponddotco merged 6 commits intotrunkfrom
alan/fix-styling-issues
Apr 15, 2025
Merged

Alan/fix styling issues#4
jamesponddotco merged 6 commits intotrunkfrom
alan/fix-styling-issues

Conversation

@Rayuaz
Copy link
Collaborator

@Rayuaz Rayuaz commented Apr 13, 2025

What does this PR do?

  • Adds a background to the header cards on all inner pages.
  • Fixes many styling issues related to rich text element, such as lists not having styles.
  • Tweaks spacings issues throughout the app.
  • Reduces repetitiveness by creating a uSurface utility class for surfaces.

Additional Notes

Home

Before After
image image

Package Page

Before After
image image

Privacy Policy Page

Before After
image image

404 Page

Before After
image image

Review checklist

Before submitting your PR, please review the following:

  • I have read the CONTRIBUTING.md file.
  • My changes are focused and address a single concern.
    • Debatable, but the changes are pretty interdependant and don't involve any logic, only styles.
  • I have added/updated tests that prove my fix is effective or that
    my feature works.
  • New and existing tests pass locally with my changes.
  • I have added necessary documentation or made changes to
    documentation (if appropriate).
  • My changes generate no new warnings or errors.
  • My code follows the code style of this project.

Developer's certificate of origin

By submitting this pull request, I certify that:

  • The contribution is my own original work.
  • I have the right to submit it under the project's license.
  • I understand and agree to the project's contributing guidelines.

Comment on lines +9 to 14
body {
color: $fgSecondary;
font-family: system-ui, sans-serif;
font-size: 1rem;
font-size: 1.125rem;
line-height: 1.5;
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were using 1.125rem as the text size pretty much everywhere, so I went ahead and made it the default (and set in on body instead of html because then it keeps the root element as 16px.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I removed the classes on the text elements because they are not needed. It's just a rich text content and it's better to let the default styles handle them.

Rayuaz added 6 commits April 13, 2025 15:32
Signed-off-by: Alan Fernandes <alan@cipher.host>
Signed-off-by: Alan Fernandes <alan@cipher.host>
Signed-off-by: Alan Fernandes <alan@cipher.host>
Signed-off-by: Alan Fernandes <alan@cipher.host>
Signed-off-by: Alan Fernandes <alan@cipher.host>
Signed-off-by: Alan Fernandes <alan@cipher.host>
@Rayuaz Rayuaz force-pushed the alan/fix-styling-issues branch from b8c42b0 to 0eba8e4 Compare April 13, 2025 18:37
Comment on lines -92 to -93
<div class="package__instructions">
<div class="package__instructionsSection uRichText">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I removed this unnecessary .package__instructionsSection section and added .uRichText to its parent, so it can handle the spacing with the default text styles.

@Rayuaz Rayuaz requested a review from jamesponddotco April 13, 2025 18:43
Copy link
Contributor

@jamesponddotco jamesponddotco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@jamesponddotco jamesponddotco merged commit 506a08f into trunk Apr 15, 2025
7 checks passed
@jamesponddotco jamesponddotco deleted the alan/fix-styling-issues branch April 15, 2025 00:51
@jamesponddotco jamesponddotco mentioned this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants