Actually include the config digest in the TOC computation#691
Open
mtrmac wants to merge 1 commit intocontainers:mainfrom
Open
Actually include the config digest in the TOC computation#691mtrmac wants to merge 1 commit intocontainers:mainfrom
mtrmac wants to merge 1 commit intocontainers:mainfrom
Conversation
mtrmac
force-pushed
the
toc-digests
branch
2 times, most recently
from
fab5704 to
9e3f252
Compare
Member
|
@mtrmac looks like you need a rebase, and the Skopeo test seems unhappy. |
... as, previously, the commit meessage claimed we do. Otherwise we could easily deduplicate images with different configs or even different (non-chunked-pulled) layers. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Contributor
Author
|
Rebased. |
Member
|
LGTM |
Member
Can you do a test vendor in podman to see if this breaks anything, if it doesn't break any tests we can merge this anytime without blocking others |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as, previously, the commit meessage claimed we do.
Otherwise we could easily deduplicate images with different configs or even different (non-chunked-pulled) layers.
(Full disclosure: I did not actually test this.)