Skip to content

Actually include the config digest in the TOC computation #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mtrmac wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Actually include the config digest in the TOC computation #691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions image/storage/storage_dest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,6 +841,8 @@ func (s *storageImageDestination) computeID(m manifest.Manifest) (string, error)
// ordinaryImageID is a digest of a config, which is a JSON value.
// To avoid the risk of collisions, start the input with @ so that the input is not a valid JSON.
tocIDInput.WriteString("@With TOC:")
tocIDInput.WriteString(ordinaryImageID)
tocIDInput.WriteByte('|') // "|" can not be present in a digest, so this is an unambiguous separator.
hasLayerPulledByTOC := false
for i, li := range layerInfos {
trusted, ok := s.trustedLayerIdentityDataLocked(i, li.Digest)
Expand Down
Loading