Dialect: Fix get_table_names() reflection method#10
Merged
Conversation
amotl
force-pushed
the
amo/type-float-vector
branch
from
56bd4b6 to
1070b37
Compare
amotl
force-pushed
the
amo/fix-inspector
branch
from
01218be to
2f08b2a
Compare
surister
reviewed
Dec 22, 2023
matriv
approved these changes
Dec 23, 2023
amotl
force-pushed
the
amo/type-float-vector
branch
from
1070b37 to
5ddc8e1
Compare
amotl
force-pushed
the
amo/fix-inspector
branch
from
2f08b2a to
43c45fb
Compare
amotl
changed the title
get_table_names() reflection methodget_table_names() reflection method
surister
force-pushed
the
amo/fix-inspector
branch
from
7198467 to
62a6bb4
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Member
|
This item is reviewed and the missing things done, we can merge it @amotl |
Member
Author
Excellent. Thank you very much. Please note it is a stacked PR, so others need to be merged first, or the branch needs to be set up differently. Otherwise, it will cause a mess at GH-9. |
amotl
force-pushed
the
amo/type-float-vector
branch
14 times, most recently
from
0f85790 to
20443d2
Compare
amotl
force-pushed
the
amo/fix-inspector
branch
2 times, most recently
from
632ca49 to
8d8e732
Compare
This comment was marked as resolved.
This comment was marked as resolved.
amotl
requested review from
seut and
surister
and removed request for
hammerhead
surister
approved these changes
Jun 10, 2024
seut
approved these changes
Jun 12, 2024
amotl
force-pushed
the
amo/type-float-vector
branch
2 times, most recently
from
9557d1c to
36d8b3d
Compare
…gument It did not respect the `schema` query argument in SQLAlchemy connection URLs. Co-authored-by: Marios Trivyzas <5058131+matriv@users.noreply.github.com>
amotl
force-pushed
the
amo/fix-inspector
branch
2 times, most recently
from
9020756 to
6ac0a22
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
We don't know which circumstances cause this problem. SQLAlchemy 1.3 is
EOL anyway, so we don't care too much.
sqlalchemy.exc.InvalidRequestError: When initializing mapper mapped
class RootStore->root, expression 'ItemStore' failed to locate a name
('ItemStore').
This was referenced Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
The
get_table_names()reflection method did not respect theschemaquery argument in SQLAlchemy connection URLs.This improvement has been used successfully on a few downstream projects and is known as the inspector patch. This patch brings it to mainline.
References
Backlog