Skip to content

Fix CRAN-blocking issues for package submission#20

Merged
Arshammik merged 1 commit intomainfrom
fix/cran-blocking-issues
Nov 16, 2025
Merged

Fix CRAN-blocking issues for package submission#20
Arshammik merged 1 commit intomainfrom
fix/cran-blocking-issues

Conversation

@Arshammik
Copy link
Collaborator

@Arshammik Arshammik commented Nov 15, 2025

This commit addresses critical issues that would prevent CRAN acceptance:

  1. Remove .onLoad auto-install (CRAN policy violation)

    • Removed automatic package installation from R/zzz.R
    • Dependencies should only be declared in DESCRIPTION file
  2. Fix Makevars.linux portability

    • Removed -march=native flag that causes binary incompatibility
    • Binaries will now work across different CPU architectures
  3. Fix thread safety issues in C++ code

    • Converted static bool to std::atomic in deviance_gene.cpp
    • Converted static bool to std::atomic in calcDeviances.cpp
    • Used compare_exchange_strong for thread-safe one-time printing
  4. Clean up code quality issues

    • Fixed typos in R/feature_selection.R comments
    • Removed unreachable code after return statement
    • Fixed typo

This commit addresses critical issues that would prevent CRAN acceptance:

1. Remove .onLoad auto-install (CRAN policy violation)
   - Removed automatic package installation from R/zzz.R
   - Dependencies should only be declared in DESCRIPTION file

2. Fix Makevars.linux portability
   - Removed -march=native flag that causes binary incompatibility
   - Binaries will now work across different CPU architectures

3. Fix thread safety issues in C++ code
   - Converted static bool to std::atomic<bool> in deviance_gene.cpp
   - Converted static bool to std::atomic<bool> in calcDeviances.cpp
   - Used compare_exchange_strong for thread-safe one-time printing

4. Clean up code quality issues
   - Fixed typos in R/feature_selection.R comments
   - Removed unreachable code after return statement
   - Fixed typo "Requirments" -> "Requirements" in README.md
@Arshammik Arshammik merged commit 7214c5a into main Nov 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant