This repository was archived by the owner on Sep 6, 2024. It is now read-only.
Utilise GitHub actions instead of CircleCI#27
Open
mrgambal wants to merge 3 commits intodatamindedbe:masterfrom
Open
Utilise GitHub actions instead of CircleCI#27mrgambal wants to merge 3 commits intodatamindedbe:masterfrom
mrgambal wants to merge 3 commits intodatamindedbe:masterfrom
Conversation
- update scalafmt; - add the sbt-updates plugin to be able to check all libs for staleness in a single action; - add GitHub Actions workflow; - drop CircleCI's stuff. - real cross-compile for the library; - try using csbt from the action "olafurpg/setup-scala"; - update SBT to 1.3.8; - tune JVM a little bit: use G1GC; - a shiny badge!
mrgambal
added a commit
to mrgambal/lighthouse
that referenced
this pull request
Apr 8, 2020
Apache Spark has embraced the GA support for 2.12 since the version 2.4.1, that was released nearly a year ago. The Amazon EMR v6.0.0 characterised by the adoption of Hadoop 3.2.1 (sic!) and Scala 2.12 (although the default JDK is still Coretto 8) has been released a month ago, hence I presume it would be nice to have cross-builds for the Lighthouse. This PR was cherry-picked from datamindedbe#27, where you can observe the matrix builds, as currently the Circle CI config supports only 2.11. Changelog: - enable cross-version builds for the projects; - fix compile-time warning.
- a tiny simplification of auto-generated code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actions now look like this.
The CodeClimate page may be observed here.
In case this PR (created more out of pure curiosity rather than some real need) goes merged, the integration with CircleCI should be disabled to prevent loads of 'failed build' emails pollute somebody's mailbox.
IMPORTANT: the integration with CodeClimate tool ought to be established first: add the project in there, and put their code coverage key to the list of secrets as
CODECOV_SECRETand that should do the trick.