Conversation
There was a problem hiding this comment.
Pull request overview
This pull request migrates the datashield Python package from Poetry to uv as the package manager, adds ruff for linting and formatting, and introduces GitHub Actions workflows for CI/CD. The PR includes formatting changes across the codebase to conform to ruff standards (120-character line length, double quotes, etc.).
Changes:
- Migration from Poetry to uv package manager with hatchling build backend
- Addition of ruff linter/formatter with configuration
- GitHub Actions workflows for CI, deployment, and stale issue management
- Code formatting updates across all Python files to conform to ruff standards
- Version bump from 0.1.0 to 1.0.0 and license change from LGPL to GPL-3.0-only
Reviewed changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | New lock file for uv package manager with all dependencies |
| pyproject.toml | Migrated from Poetry format to standard Python project format with hatchling |
| poetry.lock | Removed Poetry lock file |
| datashield/init.py | Formatted imports to use explicit re-exports |
| datashield/api.py | Applied ruff formatting and fixed duplicate method issue |
| datashield/interface.py | Applied ruff formatting, fixed duplicate is_client_error method |
| tests/test_logins.py | Applied ruff formatting but introduced test bugs |
| .ruff.toml | New ruff configuration file |
| Makefile | Updated to use uv commands instead of Poetry |
| .gitignore | Added VSCode and debug-related entries |
| .github/workflows/ci.yml | New CI workflow for testing and linting |
| .github/workflows/deploy.yml | New deployment workflow for PyPI publishing |
| .github/workflows/stale.yml | New workflow for managing stale issues |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.