feat: Add script for updating the base of all charms to Ubuntu 24.04#6
feat: Add script for updating the base of all charms to Ubuntu 24.04#6mvlassis wants to merge 6 commits intodeusebio:mainfrom
24.04#6Conversation
There was a problem hiding this comment.
Why not changing the kubeflow-repos.yaml? My idea was to have one file that we could re-use with all of the repositories
There was a problem hiding this comment.
I would skip these honestly. I suppose it is easy (and custom to the user case) select from the full list depending on the confidence we have on the modification and which modifications. I would nudge against having too many files in the presets, but just what would get used the most.
If we want to say that the process we have ALWAYS goes through the same repo first, and then roll out to the rest, that's fine (but at least for the rest I would use the kubeflow-full)
| with open("./credentials.json", "r") as fid: | ||
| credentials = GitCredentials(**json.loads(fid.read())) | ||
|
|
||
| tmp_folder = f"/home/ubuntu/tmp/kfcicli/charm_repos" |
There was a problem hiding this comment.
todo Could you just use the same args parsing as here?
| ) | ||
|
|
||
| with open("body.md", "r") as f: | ||
| pr_body = f.read() |
2 participants
This PR contains a new folder, named
kf7415-update-base, which contains a Python script for updating the on all charmed kubeflow repos.Specifically, all repos that needed an upgrade were concatenated to a new preset (under
presets) namedkubeflow-full.yaml.The script clones each repo, and opens a new PR after doing the following:
update-deps.shwhich updates the dependencies withpip-compile.charmcraft.yamlfile with a new one that has24.04as a base.contraints.txtsetup-pythonblock from all CI files