change order of some rules to avoid warnings#106
Closed
fw8 wants to merge 1 commit intodevops-coop:masterfrom
Closed
change order of some rules to avoid warnings#106fw8 wants to merge 1 commit intodevops-coop:masterfrom
fw8 wants to merge 1 commit intodevops-coop:masterfrom
Conversation
place tcp-request, http-request and http-response rules in front of reqxxx and rspxxx rules to avoid warnings like: [WARNING] 327/172846 (4677) : parsing [/etc/haproxy/haproxy.cfg:110] : a 'http-request' rule placed after a 'reqadd' rule will still be processed before.
Collaborator
|
Thanks again for your contribution, Florian. Unfortunately we cannot accept this PR because big changes are coming to this role (#107)! As you are well aware, the current role is not very flexible and requires frequent changes to adapt to users' requirements. The next major version of this role introduces a flexible configuration syntax that obsoletes these trivial changes. You can read a description of the new syntax here: Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
place tcp-request, http-request and http-response rules in front of reqxxx and rspxxx rules to avoid warnings like:
[WARNING] 327/172846 (4677) : parsing [/etc/haproxy/haproxy.cfg:110] : a 'http-request' rule placed after a 'reqadd' rule will still be processed before.