Open
Conversation
Sort keys first by weight, then alphabetically. This avoids rewriting the configuration file on each run, particularly if Ansible users use different versions of Python (dictionaries are ordered in Python 3.6).
This was referenced Nov 28, 2017
|
Hi, |
Collaborator
|
This is a heavy rewrite that looks quiet interesting. |
|
Any chance to merge it? |
k3nny0ne
reviewed
Mar 5, 2018
| {%- for request in requests -%} | ||
| http-request {{ request.action }}{% if request.param is defined %} {{ request.param }}{% endif %}{% if request.condition is defined %} {{ request.condition }}{% endif %} | ||
| {% else %} | ||
| {% for name, options in (instances|dictsort(case_sensitive=True)).items() %} |
There was a problem hiding this comment.
'items()' will produce error: AnsibleUndefinedVariable: 'list object' has no attribute 'items'
Vars:
haproxy_frontends:
rgw_http:
bind:
- ':80'
reqadd:
- 'X-Forwarded-Proto:\ http'
default_backend: rgw
Collaborator
Author
|
@k3nny0ne Sorry for keeping you waiting. I missed your review. I'll address your feedback today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
haproxy.cfgtemplate.mailersandpeerssections.This changeset will significantly reduce maintenance work and user frustration, since users will not need to hack the role or submit pull requests to add new options.
This is a breaking change and will require a major release.
Resolves: #54, #56, #77, #87
Obsoletes: #105, #106