Week 1: Implement sign up page for Paint Quote System#21
Open
DevHuo wants to merge 1 commit intodistinctioncoding:mainfrom
Open
Week 1: Implement sign up page for Paint Quote System#21DevHuo wants to merge 1 commit intodistinctioncoding:mainfrom
DevHuo wants to merge 1 commit intodistinctioncoding:mainfrom
Conversation
Author
|
Thanks! |
| <form class="sign-up-form" action="/signUp" method="get"> | ||
| <label for="name">Your name</label> | ||
| <input type="text" name="name" id="name" placeholder="Enter your name"> | ||
| <br> |
There was a problem hiding this comment.
you should use margin-bottom to replace br
Comment on lines
+35
to
+39
| .divider { | ||
| width: 395px; | ||
| border-top: 1.5px solid #134d74; | ||
| margin-bottom: 12px; | ||
| } |
There was a problem hiding this comment.
divider exceeds its parent element's width, 395px>307px
Comment on lines
+20
to
+28
| .sign-up-intro { | ||
| flex: 0.6; | ||
| } | ||
|
|
||
| .sign-up-intro { | ||
| color: #134d74; | ||
| font-size: 16px; | ||
| width: 307px; | ||
| } |
There was a problem hiding this comment.
since you have set flex:0.6, there is no need to specifcially set its width
当视窗窗口宽度很大的时候，两个container会分离的很开，我看到你加了space-between, 可以再加一个max-width作限制，或者可以自行查询其他的方法 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a new sign-up page with a responsive design and a background image.
Changes
sign-up.htmlfor the sign-up screenstyle.cssfor layout and stylingsignup-background-image.pngas the page background image