-
Notifications
You must be signed in to change notification settings - Fork 20
Week 1: Implement sign up page for Paint Quote System #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DevHuo
wants to merge
1
commit into
distinctioncoding:main
Choose a base branch
from
DevHuo:week-one
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Sign up</title> | ||
|
|
||
| <link rel="stylesheet" href="style.css"> | ||
| </head> | ||
| <body> | ||
|
|
||
| <div class="sign-up-page"> | ||
| <div class="sign-up-intro"> | ||
| <h1>Welcome to Paint Quote System</h1> | ||
| <hr class="divider"> | ||
| <p>Consequat adipiscing ea do labore irure adipiscing</p> | ||
| <p>occaecat cupidatat excepteur duis mo</p> | ||
| </div> | ||
|
|
||
| <div class="sign-up-card"> | ||
| <h2>Sign Up</h2> | ||
| <p class="sign-up-card-subtitle">Enter details to create your account</p> | ||
|
|
||
| <form class="sign-up-form" action="/signUp" method="get"> | ||
| <label for="name">Your name</label> | ||
| <input type="text" name="name" id="name" placeholder="Enter your name"> | ||
| <br> | ||
| <label for="phone-number">Phone number</label> | ||
| <input type="tel" name="phone-number" id="phone-number" placeholder="Enter your phone number"> | ||
| <br> | ||
| <label for="account">Dulux account</label> | ||
| <input type="text" name="account" id="account" placeholder="Enter your Dulux account"> | ||
|
|
||
| <button type="submit">Sign up</button> | ||
| </form> | ||
|
|
||
| <p class="sign-up-footer-text">Already have an account? | ||
| <a href="Login.html">Sign in</a> | ||
| </p> | ||
|
|
||
| </div> | ||
|
|
||
| </div> | ||
|
|
||
| </body> | ||
| </html> | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| *{ | ||
| font-family: Arial, Helvetica, sans-serif; | ||
| margin: 0; | ||
| padding: 0; | ||
| } | ||
|
|
||
| .sign-up-page { | ||
| background-image: url("signup-background-image.png"); | ||
| height: 100vh; | ||
| background-repeat: no-repeat; | ||
| background-size: cover; | ||
|
|
||
| display: flex; | ||
| align-items: center; | ||
|
|
||
| justify-content: space-between; | ||
| padding: 0 80px; | ||
| } | ||
|
|
||
| .sign-up-intro { | ||
| flex: 0.6; | ||
| } | ||
|
|
||
| .sign-up-intro { | ||
| color: #134d74; | ||
| font-size: 16px; | ||
| width: 307px; | ||
| } | ||
|
Comment on lines
+20
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since you have set flex:0.6, there is no need to specifcially set its width |
||
|
|
||
| .sign-up-intro h1 { | ||
| margin-bottom: 12px; | ||
| font-size: 26px; | ||
| } | ||
|
|
||
| .divider { | ||
| width: 395px; | ||
| border-top: 1.5px solid #134d74; | ||
| margin-bottom: 12px; | ||
| } | ||
|
Comment on lines
+35
to
+39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. divider exceeds its parent element's width, 395px>307px |
||
|
|
||
| .sign-up-card { | ||
| max-width: 380px; | ||
| width: 100%; | ||
| background-color: white; | ||
| border-radius: 12px; | ||
| box-shadow: 0 10px 30px rgba(0, 0, 0, 0.4); | ||
| height: 430px; | ||
| padding: 30px; | ||
| margin: auto; | ||
| } | ||
|
|
||
| .sign-up-card h2 { | ||
| text-align: center; | ||
| margin-bottom: 8px; | ||
| } | ||
|
|
||
| .sign-up-card-subtitle { | ||
| text-align: center; | ||
| margin-bottom: 30px; | ||
| font-size: 14px; | ||
| color: gray; | ||
| } | ||
|
|
||
| .sign-up-form { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 5px; | ||
| } | ||
|
|
||
| .sign-up-form label { | ||
| font-size: 14px; | ||
| color: #555; | ||
| } | ||
|
|
||
| .sign-up-form input { | ||
| padding: 12px; | ||
| border-radius: 6px; | ||
| border: 1px solid #ccc; | ||
| } | ||
|
|
||
| .sign-up-form button { | ||
| margin-top: 16px; | ||
| padding: 14px; | ||
| border: none; | ||
| border-radius: 6px; | ||
| background-color: #0077a3; | ||
| color: white; | ||
| font-size: 16px; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .sign-up-footer-text { | ||
| margin-top: 16px; | ||
| text-align: center; | ||
| font-size: 14px; | ||
| color: gray; | ||
| } | ||
|
|
||
| .sign-up-footer-text a { | ||
| text-decoration: none; | ||
| } | ||
|
|
||
| .sign-up-footer-text a:hover { | ||
| text-decoration: underline; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should use margin-bottom to replace br