fix support of relative variable overrides#1771
Conversation
|
Thanks for your pull request, @MartinNowak! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Hmm the |
posix.mak
Outdated
| STDDOC="$(addprefix $(PWD)/, $(STD_DDOC))" \ | ||
| DMD="$(DMD_STABLE)" \ | ||
| DRUNTIME_PATH="${DRUNTIME_DIR}" \ | ||
| DMD="$(realpath $(DMD_STABLE))" \ |
There was a problem hiding this comment.
Please no realpath, it resolves symlinks, and the final paths (which may be temporary and expose implementation details) end up all over the place, sometimes even in outputs.
There was a problem hiding this comment.
It's what we've used during the previous years, but I could use make's abspath if that helps.
This is unrelated to this change and was introduced here #1687 (comment). |
Maybe, but it would fix the broken build on DAutoTest. |
- broken by 4129e45 which changed target folders from ../druntime-2.074.1 to $PWD/druntime-2.074.1 - no need to make those targets absolute since the makefile will always run in the dlang.org root folder
f127679 to
2efc3fd
Compare
|
Also fixes the clone targets now. |
Btw as |
It's fine for the moment and not much effort. |
No description provided.