Closed
Conversation
- broken by 4129e45 which changed target folders from ../druntime-2.074.1 to $PWD/druntime-2.074.1 - no need to make those targets absolute since the makefile will always run in the dlang.org root folder
Contributor
|
Thanks for your pull request, @MartinNowak! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
wilzbach
approved these changes
Jun 26, 2017
Contributor
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
LGTM, sorry for causing yet another outage at the nightly build server. I might submit a short follow-up with #1771 (comment)
Contributor
Member
Author
|
I see, needs to be incorporated with #1771 due to $PWD in the DMD_DIR et.al. vars. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
../druntime-2.074.1 to $PWD/druntime-2.074.1
always run in the dlang.org root folder