Turn semicolon as empty statement into an error

[dkorpel]

It's been a while: #6886

[dlang-bot]

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15072"

[thewilsonator]

Just double checking this is still allowed in importC

[ljmf00]

What about the other empty statements? CC @JohanEngelen we have a lot of those.

[JohanEngelen]

What about the other empty statements? CC @JohanEngelen we have a lot of those.

deprecations are already treated as errors, so if this is not adding more deprecations/errors, we're fine.

[dkorpel]

What about the other empty statements?

What other empty statements? { } is allowed.

[dkorpel]

Just double checking this is still allowed in importC

Yes, cparseStatement always allowed a semicolon as an empty statement, it never actually checked the semi or semiOk flag.

[ljmf00]

What about the other empty statements?

What other empty statements? { } is allowed.

Sorry, I just got confused with empty declarations 🙃

[WalterBright]

It always has resulted in an error.

@dkorpel ??

[dkorpel]

The changelog's example is wrong, you can see the new error in the diff of the test file.