Deduplicate repeated branch body in conditional chain#28
Merged
mkoncek merged 1 commit intofedora-java:mainfrom Jul 23, 2025
Merged
Deduplicate repeated branch body in conditional chain#28mkoncek merged 1 commit intofedora-java:mainfrom
mkoncek merged 1 commit intofedora-java:mainfrom
Conversation
Simplify control flow by merging two branches with identical bodies into a single condition. This removes redundancy and improves readability without changing behavior.
mkoncek
reviewed
Jul 22, 2025
Member
mkoncek
left a comment
mkoncek
left a comment
There was a problem hiding this comment.
Since you want to deduplicate code, there is an even shorter way:
if (auto substr = content.substr(position, 2); substr == "\\\\" or substr == "\\\"")If i remember correctly, this is valid in C++2a.
Member
Author
|
Sure, I can make it even more compact. An alternative that not only fixes static analysis warnings, but also simplifies code logic is opened as #33. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify control flow by merging two branches with identical bodies into a single condition. This removes redundancy and improves readability without changing behavior.