Simplify character and string literal parsing logic#33
Closed
mizdebsk wants to merge 1 commit intofedora-java:mainfrom
Closed
Simplify character and string literal parsing logic#33mizdebsk wants to merge 1 commit intofedora-java:mainfrom
mizdebsk wants to merge 1 commit intofedora-java:mainfrom
Conversation
Refactor and simplify parsing logic for character and string literals within find_token(). Merge redundant conditional branches, reduce unnecessary control flow, and replace multi-line loops with more concise equivalents.
Member
Author
|
This is an alternative to #28 that not only fixes static analysis warnings, but also simplifies code logic. |
Member
|
When looking at this, I realize why I wrote it like I did. I find the verbose code actually more readable. It almost reads like a sentence. I don't like compressing more operations into a single line. |
Member
Author
|
Feel free to close it in favor of #28, which preserves readability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor and simplify parsing logic for character and string literals within find_token(). Merge redundant conditional branches, reduce unnecessary control flow, and replace multi-line loops with more concise equivalents.