Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4559 +/- ##
==========================================
- Coverage 73.50% 73.46% -0.04%
==========================================
Files 482 482
Lines 17678 17678
Branches 3493 3493
==========================================
- Hits 12994 12988 -6
- Misses 3796 3800 +4
- Partials 888 890 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
To make room for Android potentially coming later.
7 tasks
Collaborator
Author
|
@sentry review |
Allows running Android integration tests on Windows
To avoid requiring `adb` in `PATH`
Now `pwsh integration-test/android.Tests.ps1` device/emulator discovery works without adb in PATH or ANDROID_SERIAL explicitly defined.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Flash0ver
reviewed
Oct 6, 2025
Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| # by Android Device Tests, or manually when testing locally. This avoids | ||
| # slowing down non-Device Test CI builds further. | ||
| Install-XHarness | ||
| $script:emulator = Get-AndroidEmulatorId |
Collaborator
There was a problem hiding this comment.
TIL about $script scoped variables in PWSH!
jamescrosswell
approved these changes
Oct 6, 2025
Collaborator
jamescrosswell
left a comment
jamescrosswell
left a comment
There was a problem hiding this comment.
Left one non-blocking suggestion, but otherwise LGTM 🎉
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Technically, less correct but doesn't fail even if port forwarding had failed. This way, we can keep it simple and don't need to track it separately.
Collaborator
Author
|
Thanks for testing and helping! |
alexsohn1126
pushed a commit
that referenced
this pull request
Oct 11, 2025
Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com> Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
This was referenced Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps verify that crash events are captured as expected after Cocoa and Java SDK updates (and eventually getsentry/sentry-cocoa#6193):
CrashType.ManagedCrashType.NativeNullReferenceExceptionFor example, see
#skip-changelog
Note
Adds MAUI-based Android and iOS integration tests executed on emulators/simulators in CI, with supporting test app, utilities, and workflow updates (including retries and result artifacts).
integration-test/android.Tests.ps1with retry; checkout submodules; set up Java 17; fetch sharedgithub-workflows; reuse emulator config via YAML anchors; upload bothtest_outputandintegration-test/mobile-app/test_output.integration-test/ios.Tests.ps1with retry; upload both result paths.scriptsin sparse checkout for publishing builds.integration-test/net9-maui/**) targetingnet9.0-android35.0andnet9.0-ios18.0to drive crash scenarios and verify envelopes.integration-test/android.Tests.ps1,integration-test/ios.Tests.ps1; shared helpers inintegration-test/pester.ps1.scripts/device-test-utils.ps1(XHarness install, emulator/simulator helpers);scripts/device-test.ps1now uses these helpers and simplifies simulator selection.integration-test/common.ps1to source shared Pester extensions.Written by Cursor Bugbot for commit 8144e87. This will update automatically on new commits. Configure here.