Skip to content

Change CelUnknownSet to use Sets.union and SetView.immutableCopy, which builds the copy using a pre-sized builder to avoid churn on the internal hash table. #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 2, 2025
Merged

Change CelUnknownSet to use Sets.union and SetView.immutableCopy, which builds the copy using a pre-sized builder to avoid churn on the internal hash table. #738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions runtime/src/main/java/dev/cel/runtime/CelUnknownSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import com.google.auto.value.AutoValue;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Sets;

/**
* Unknown set representation.
Expand Down Expand Up @@ -65,14 +66,8 @@ private static CelUnknownSet create(

public static CelUnknownSet union(CelUnknownSet lhs, CelUnknownSet rhs) {
return create(
ImmutableSet.<CelAttribute>builder()
.addAll(lhs.attributes())
.addAll(rhs.attributes())
.build(),
ImmutableSet.<Long>builder()
.addAll(lhs.unknownExprIds())
.addAll(rhs.unknownExprIds())
.build());
Sets.union(lhs.attributes(), rhs.attributes()).immutableCopy(),
Sets.union(lhs.unknownExprIds(), rhs.unknownExprIds()).immutableCopy());
}

public CelUnknownSet merge(CelUnknownSet rhs) {
Expand Down
Loading