feat: add TypedItem to allow for psr/cache:3#364
Merged
Conversation
google-cla
bot
added
the
cla: yes
Geolim4
reviewed
Sep 25, 2021
6 tasks
google-cla
bot
added
cla: no
bshaffer
force-pushed
the
add-typed-cache-item
branch
from
596ec7e to
7365613
Compare
google-cla
bot
added
cla: yes
noahdietz
approved these changes
Apr 6, 2022
noahdietz
left a comment
noahdietz
left a comment
There was a problem hiding this comment.
I will Approve, but perhaps double check with @dwsupplee that the BC is OK? Feel like I'm still learning a bit in these repos.
dwsupplee
suggested changes
Apr 6, 2022
Contributor
dwsupplee
left a comment
dwsupplee
left a comment
There was a problem hiding this comment.
I agree the surface for the BC break is small enough to warrant the support here 👍 , LGTM with a few minor notes.
Contributor
Author
|
@dwsupplee all done here! |
dwsupplee
approved these changes
Apr 11, 2022
|
Alleluia 🥳 Thank you to all participants. |
Contributor
Author
|
This is now released in v1.20.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports
psr/cache:3.0and addresses #363This PR raises the minimum version supported to PHP 7.1 and adds return types to
SysvCacheItemPoolandMemoryCacheItemPoolThis change will break BC for anyone extending
SysvCacheItemPool, but I imagine this is a very unlikely scenario.