fix: pass header and footer through in Java snapshot PRs#2685
Open
zeitlinger wants to merge 1 commit intogoogleapis:mainfrom
Open
fix: pass header and footer through in Java snapshot PRs#2685zeitlinger wants to merge 1 commit intogoogleapis:mainfrom
zeitlinger wants to merge 1 commit intogoogleapis:mainfrom
Conversation
The `buildSnapshotPullRequest()` method in the Java strategy was constructing a `PullRequestBody` without passing the configured `pullRequestHeader` and `pullRequestFooter`, causing these options to be silently ignored for Java snapshot PRs. This is especially visible for single-package repos where `separatePullRequests` defaults to `true` and the Merge plugin (which would otherwise apply the footer) does not run. Fixes the TODO comment that was already in the code asking about this. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This was referenced Feb 20, 2026
zeitlinger
added a commit
to grafana/flint
that referenced
this pull request
Feb 20, 2026
…around (#42) ## Summary - Remove `separate-pull-requests: false` added in #40 - That workaround is only needed for Java snapshot PRs (upstream bug: googleapis/release-please#2685) - Flint uses `release-type: simple`, so the footer works without it Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
buildSnapshotPullRequest()method in the Java strategy constructsa
PullRequestBodywithout passing the configuredpullRequestHeaderand
pullRequestFooter, causing these options to be silently ignoredfor Java snapshot PRs.
This is especially visible for single-package repos where
separatePullRequestsdefaults totrueand the Merge plugin(which would otherwise apply the footer) does not run.
Changes
this.pullRequestHeaderandthis.pullRequestFootertoPullRequestBodyinjava.ts:buildSnapshotPullRequest()Context
Discovered while configuring
pull-request-footeronprometheus/client_java
— a single-package Java repo where the footer was silently ignored
on the SNAPSHOT PR.