Merged
Conversation
Member
spaenleh
commented
Feb 25, 2026
spaenleh
commented
- fix: use node:path instead of path
- fix: default object value
- fix: do not use default object value
- fix: remove unnecessary casting
spaenleh
force-pushed
the
clean-code-smells
branch
from
2270d6c to
57b18f9
Compare
spaenleh
force-pushed
the
clean-code-smells
branch
from
57b18f9 to
cf70702
Compare
spaenleh
force-pushed
the
clean-code-smells
branch
from
cf70702 to
606d551
Compare
pyphilia
approved these changes
Feb 26, 2026
Contributor
pyphilia
left a comment
pyphilia
left a comment
There was a problem hiding this comment.
All good for me, I'll let you revert node:path because it doesn't compile for cypress 🥲
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.