Skip to content

fix: code smells #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyphilia merged 5 commits into from
Feb 26, 2026
Merged

fix: code smells #1207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5d52dc
fix: use node:path instead of path
spaenleh Feb 25, 2026
f6009ab
fix: default object value
spaenleh Feb 25, 2026
d020fb7
fix: do not use default object value
spaenleh Feb 25, 2026
606d551
fix: remove unnecessary casting
spaenleh Feb 25, 2026
d09b456
fix: remove fix for node:path since webpack exploses
spaenleh Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cypress/e2e/builder/item/publish/ccLicense.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,9 @@ const setUpAndVisitItemPage = (item: ItemForTest) => {
openPublishItemTab(item.id);
};

const openLicenseModal = (
{ hasALicense }: { hasALicense: boolean } = { hasALicense: true },
) =>
const openLicenseModal = ({
hasALicense = true,
}: { hasALicense?: boolean } = {}) =>
cy
.get(
buildDataCyWrapper(
Expand Down
18 changes: 6 additions & 12 deletions cypress/e2e/builder/item/publish/publishedItem.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ const waitOnItemValidation = (item: PackedItem) => {

const waitOnPublishItem = (
item: PackedItem,
{ shouldNotify }: { shouldNotify: boolean } = { shouldNotify: false },
{ shouldNotify = false }: { shouldNotify?: boolean } = {},
) => {
cy.wait('@publishItem').then((data) => {
const {
Expand Down Expand Up @@ -149,9 +149,7 @@ describe('Private Item', () => {

describe('Ready to Publish Item', () => {
const status = PublicationStatus.ReadyToPublish;
const itemValidationGroup = ItemValidationGroupFactory(
privateItem,
) as ItemValidationGroup;
const itemValidationGroup = ItemValidationGroupFactory(privateItem);

beforeEach(() => {
setUpAndVisitItemPage(privateItem, {
Expand Down Expand Up @@ -179,7 +177,7 @@ describe('Private Item', () => {
const status = PublicationStatus.Invalid;
const itemValidationGroup = ItemValidationGroupFactory(privateItem, {
status: ItemValidationStatus.Failure,
}) as ItemValidationGroup;
});

beforeEach(() => {
setUpAndVisitItemPage(privateItem, {
Expand Down Expand Up @@ -231,7 +229,7 @@ describe('Public Item', () => {
const status = PublicationStatus.Pending;
const itemValidationGroup = ItemValidationGroupFactory(publicItem, {
status: ItemValidationStatus.Pending,
}) as ItemValidationGroup;
});

beforeEach(() => {
setUpAndVisitItemPage(PublishedItemFactory(publicItem), {
Expand All @@ -256,9 +254,7 @@ describe('Public Item', () => {

describe('Ready to Publish Item', () => {
const status = PublicationStatus.ReadyToPublish;
const itemValidationGroup = ItemValidationGroupFactory(
publicItem,
) as ItemValidationGroup;
const itemValidationGroup = ItemValidationGroupFactory(publicItem);

beforeEach(() => {
setUpAndVisitItemPage(publicItem, {
Expand Down Expand Up @@ -288,9 +284,7 @@ describe('Public Item', () => {

describe('Published Item', () => {
const status = PublicationStatus.Published;
const itemValidationGroup = ItemValidationGroupFactory(
publicItem,
) as ItemValidationGroup;
const itemValidationGroup = ItemValidationGroupFactory(publicItem);

beforeEach(() => {
setUpAndVisitItemPage(PublishedItemFactory(publicItem), {
Expand Down